ci: Use arm-native-runner for kvm builds on aarch64-linux - #2319
Merged
Conversation
PostgreSQL Extension Dependency Analysis: PR #2319
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2319
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
soedirgo
approved these changes
Jul 28, 2026
Contributor
|
@mmlb the plan for having the GUC set to WARN i.e. |
mmlb
marked this pull request as draft
July 28, 2026 14:22
Collaborator
Author
|
good call @utkarash2991 I was working off of your changes so I could trigger the tests and make sure it actually fixed things. Marking draft so I don't merge by mistake... |
mmlb
force-pushed
the
push-uxzylxlmtrwo
branch
20 times, most recently
from
July 28, 2026 18:28
9124237 to
b51b49f
Compare
mmlb
force-pushed
the
push-uxzylxlmtrwo
branch
18 times, most recently
from
July 29, 2026 18:25
8d829fc to
3f2e62c
Compare
Collaborator
Author
|
Ok dropped your commits @utkarash2991 for testing by just gutting most of build-nix.yml and just hard coding pg_tle builds for both aarch64 and x86_64, run can be found in https://github.com/supabase/postgres/actions/runs/30477923240?pr=2319 for 8d829fc. This took a bit more refactoring of nix-install-ephemeral + users than I expected but I'm ok with that. |
…vars Better to be explicit instead of implicit.
The new images do not install anything so we no longer need force-clean. The new images don't have python nor aws installed either because we don't actually need them as evidenced by this patch. Having to pass multi-user input in was a temporary solution for qemu-image builds and doing so now for the nixos vm tests would be quite a pain, so lets drop it. Instead of an input lets detect the environment we are running in and do the right thing. I split the steps into scripts because they are easier to work with than scripts-in-yaml.
blacksmith does not support nested virt on aarch64 hosts so we need an alternative.
mmlb
marked this pull request as ready for review
July 29, 2026 19:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
NixOS tests require VMs and are being scheduled on blacksmith for linux builds, but that only works for x86_64-linux hosts, aarch64 fails.
What is the new behavior?
Use arm-native-runners which are currently used for qemu builds and are aarch64 only.
Additional context
In response to https://github.com/supabase/postgres/actions/runs/30160241092/job/89694722493?pr=2315
Fixes PSQL-1547