fix: add android elf build ids - #98
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This was referenced Jul 24, 2026
This comment was marked as outdated.
This comment was marked as outdated.
ovitrif
force-pushed
the
ovi/fix-ldk-android-build-ids
branch
from
July 26, 2026 20:45
61a8412 to
8cb0f2e
Compare
ovitrif
changed the title
coreyphillips
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #95
Implements the LDK producer portion of synonymdev/bitkit-android#1105.
Companion PRs:
Description
-Wl,--build-id=sha1to the Android linker flags for every published ABI while preserving the existing 16 KB page-size flags0.7.0-rc.58QA Notes
sh -n scripts/uniffi_bindgen_generate_kotlin_android.sh,cargo fmt --all -- --check,cargo test --lib --locked(77 passed), andcargo clippy --lib --locked0.7.0-rc.58Release