Skip to content

feat[frontend](settings/api-key): added apikey on settings section#2380

Merged
AlexSanchez-bit merged 1 commit into
release/v12.0.0from
backlog/v12_api-key_settings
Jul 24, 2026
Merged

feat[frontend](settings/api-key): added apikey on settings section#2380
AlexSanchez-bit merged 1 commit into
release/v12.0.0from
backlog/v12_api-key_settings

Conversation

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

🛑 AI review — Sensitive area, extra care recommended

This PR touches critical paths or introduces changes the model cannot judge with sufficient confidence. Review carefully before merging.

architecture (gemini-3-flash-lite) — clean

Summary: Refactored API keys management from a profile-embedded section to a dedicated top-level feature module.

No findings.

⚠️ bugs (gemini-3-flash-lite) — minor findings

Summary: Refactored API keys feature into a dedicated route; logic appears sound, but identified a potential UI/UX regression in the ConfirmDialog component.

  • medium frontend/src/features/api-keys/components/ConfirmDialog.tsx:23 — The 'run' function in ConfirmDialog lacks a 'busy' state management, unlike the previous implementation in the deleted file. This allows users to trigger multiple concurrent API requests by clicking the confirm button repeatedly.

🛑 security (gemini-3-flash-lite) — high/critical — please review

Summary: Refactoring of API Key management from profile-embedded to a dedicated settings route; touches security-critical authentication/authorization paths.

  • medium frontend/src/features/api-keys/pages/ApiKeysPage.tsx:77 — Hardcoded flag 'ENFORCE_ENTERPRISE_GATE = true' bypasses license checks for API Key management. Ensure this is intended for production or remove before merge.

🟢 go-deps — up to date

No pending Go dependency updates.

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor Author

click repetition (busy state) is handled on the shared confirm button already so there's no need to re implement it on api key confirm dialog (it uses shared confirm button underneath), moving api key management to a dedicated section is not a UI regression

@AlexSanchez-bit
AlexSanchez-bit merged commit e630c58 into release/v12.0.0 Jul 24, 2026
1 check passed
@AlexSanchez-bit
AlexSanchez-bit deleted the backlog/v12_api-key_settings branch July 24, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant