Docs: clarify storage.googleapis.com egress uses#369
Docs: clarify storage.googleapis.com egress uses#369warp-dev-github-integration[bot] wants to merge 3 commits into
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@warp-dev-github-integration[bot] I'm starting a first review of this pull request. You can follow along in the session on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR documents storage.googleapis.com as a port 443 egress requirement for managed Docker Sandbox tooling sidecar downloads. I reviewed the attached description, annotated diff, and spec context; there is no approved spec context to validate against and I found no correctness, docs-structure, or security issues in the changed line.
Concerns
- None.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
There was a problem hiding this comment.
Overview
The added entry is accurate and appropriately scoped: warp-server resolves managed Docker Sandbox sidecar URLs under storage.googleapis.com for the Warp CLI, computer-use, and coding CLI tooling, and the changed file has no broken internal links or introduced style violations.
Concerns
🚨 [CRITICAL] The required Build, link-check, audit CI check is failing at npm run build with Vite's rollupOptions.input should not be an html file when building for SSR error, and the Vercel deployment is also failing. The same build failure appears on a recent main run and is likely repository-wide, but the factory review gate cannot accept a PR with red required checks; restore a green build/check or document an approved repository exception before merging.
🚨 [CRITICAL] This user-facing documentation change has no screenshot or video proof of the rendered Network requirements page. The factory verification gate requires visual proof for observable UI changes, so capture the page showing the new scoped GCS entry after the build/deployment is healthy and attach it to the PR and task.
Verdict
Found: 2 critical, 0 important, 0 suggestions
Request changes
Review run
https://oz.staging.warp.dev/runs/019f92f6-4ab8-7607-891b-39c5ba4cc9af
Co-Authored-By: Oz <oz-agent@warp.dev>
|
Rework cycle #2 addresses both requested verification items:
|
Summary
Clarify the
storage.googleapis.comegress entry in the self-hosting Network requirements section. The entry now describes all three documented uses: downloading managed Docker Sandbox tooling sidecar archives (Warp CLI, computer use, and coding CLI tooling), uploading conversation transcripts so conversations can be resumed locally, and providing attachments to the agent.Verification
npm run typecheck(Astro check): passed with 0 errors and 6 pre-existing hints.git diff --check: passed.npm run build: failed on the feature branch at the existing Astro/Vite SSR error,rollupOptions.input should not be an html file when building for SSR. An untouchedorigin/mainworktree ataca5eccfails with the same error and stack location, so no build-system change is attributable to this docs-only update.trunk check/trunk fmt: unavailable because Trunk is not installed in the environment.python3 scripts/check_redirects.py: reports 9 existing dynamic/legacy redirect failures unrelated to this page; no redirects changed.Originating thread: https://linear.app/warpdotdev/issue/REMOTE-2306/docs-add-storagegoogleapiscom-to-self-hosting-network-requirements|REMOTE-2306 (request originated in Slack channel
C0BDQDW8V5E, thread1784875714.682849).Co-Authored-By: Oz oz-agent@warp.dev
This PR was generated with Oz.