run_agents resolves repo-qualified child skill specs#14271
Draft
warp-dev-github-integration[bot] wants to merge 3 commits into
Draft
run_agents resolves repo-qualified child skill specs#14271warp-dev-github-integration[bot] wants to merge 3 commits into
warp-dev-github-integration[bot] wants to merge 3 commits into
Conversation
) Commit the approved spec for QUALITY-1221 so the implementation phase can build against it on this same branch/PR. Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_agentsremote children now resolve repository-qualified child skill specs (org/repo:path/to/SKILL.mdandrepo:skill-name) in the parent client instead of requiring absolute filesystem paths. The existing active-skill lookup remains the fast path for absolute and bundled references.Implementation
resolve_skill_specresolver as a native-client fallback in the orchestration runtime.RemoteChildLaunchConfigcallers.ParsedSkillcontent into the existingruntime_skillspayload.ResolveSkillErrorreason in unresolved-skill messages.Verification
./script/formatpassed../script/check_no_inline_test_modulespassed../script/presubmitwas attempted; its formatting and inline-test stages passed, but clippy could not complete in this sandbox because the repository Cargo target/registry mounts were full. Redirecting Cargo to/tmpprogressed further, but the warp rustc process was SIGKILLed by the environment. No source-level compiler diagnostic was emitted.Originating thread: https://warpdotdev.slack.com/archives/C0BDQDW8V5E/p1784921048509639
Conversation: https://staging.warp.dev/conversation/cc9dde35-bd3d-48d2-af09-7b757324c104
Run: https://oz.staging.warp.dev/runs/019f95f3-0fc4-751e-ac48-5792a54dce14
This PR was generated with Oz.