Clean up FileTree feature flag#14308
Conversation
|
@oz-for-oss[bot] I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR removes the FileTree feature flag from Cargo/runtime feature wiring, promotes related telemetry events to always-enabled, and makes the UDI top-margin behavior unconditional when the input is pinned at the top.
Concerns
- The diff includes a user-visible layout change, but the PR description does not include screenshots or a screen recording demonstrating the final behavior.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| let margin_top = if FeatureFlag::FileTree.is_enabled() && self.is_input_at_top(&model, app) | ||
| { | ||
| // Don't include the top margin for UDI so that the UDI is flush with the file tree. | ||
| let margin_top = if self.is_input_at_top(&model, app) { |
There was a problem hiding this comment.
1 participant
Automated cleanup of the
FileTreefeature flag.This PR was generated by the feature flag cleanup workflow.