Skip to content

fix: update brace-expansion to resolve CVE-2026-13149 - #188

Merged
dannyneira merged 1 commit into
mainfrom
independabot/brace-expansion-CVE-2026-13149
Jul 27, 2026
Merged

fix: update brace-expansion to resolve CVE-2026-13149#188
dannyneira merged 1 commit into
mainfrom
independabot/brace-expansion-CVE-2026-13149

Conversation

@independabot-soc2

Copy link
Copy Markdown
Contributor

Hi, this is independabot — not Lili! You can ask her if you have questions, but she had no hand in generating this PR other than setting up the independabot schedule.

Please merge this PR yourself, if you approve.

BEFORE YOU MERGE

Instructions for resolving the vuln

Highlight the risky code / where the dependency was used

brace-expansion is a transitive dependency of minimatch (brought in via nodemon devDependency). It is only used in the build toolchain, not in the shipped bundle. Risk is low.

Special instructions for this PR

None. This is a devDependency-only change to build_ts/. The overrides field pins brace-expansion to >=1.1.16 (resolved to 5.0.8 at time of install).

AFTER YOU MERGE

No post-merge steps required.

@independabot-soc2
independabot-soc2 Bot requested a review from dannyneira July 24, 2026 13:06
@dannyneira

Copy link
Copy Markdown
Member

Holding off on approval and merge for now:

  • Major version bump: brace-expansion is being updated from 1.1.11 to 5.0.8, which crosses multiple major version boundaries (1.x to 5.x). Major bumps may include breaking changes; recommend merging separately after confirming the build toolchain (nodemon/minimatch) still behaves as expected with the pinned version.
  • CI is currently green and changes are limited to build_ts/package.json and build_ts/package-lock.json (manifest/lockfile only), which is good.

Per review policy, major-version dependency bumps are not auto-merged. Please verify the bump is safe for the build toolchain and merge manually if appropriate.

@dannyneira dannyneira left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally on a fresh clone of warpdotdev/workflows with this PR branch checked out (Node v24.15.0, npm 11.12.1).

Install: npm ci in build_ts/ succeeded (186 packages; brace-expansion resolved to 5.0.8 per the overrides block, balanced-match to 4.0.4). The repo's own prepare script (npm run build) ran during install and completed.

Build: npm run build (tsc && webpack) passed — "webpack 5.107.2 compiled successfully"; dist/warp-workflows.js (243 KiB), index.d.ts, index.js, and index.js.map emitted.

Typecheck: npx tsc --noEmit passed with no errors.

Lint / test: no lint or test scripts are defined in build_ts/package.json, so those steps are not applicable.

prepare script review (called out in the Dependabot release notes): brace-expansion 5.0.8 declares "prepare": "tshy". tshy is a standard, dev-only TypeScript dual-package build tool; npm does not run prepare for registry-installed dependencies, and tshy is listed under devDependencies (not installed transitively), so this script does not execute during npm ci. The published tarball ships pre-built dist/. No unexpected install-time behavior observed. (The transitive balanced-match@4.0.4 has the same benign prepare: tshy pattern.) brace-expansion is a transitive dependency via nodemon and is not part of the build output.

All defined verification steps pass. Safe to merge.

Add npm overrides to force brace-expansion >= 1.1.16, resolving
DoS vulnerability via exponential-time expansion of consecutive
non-expanding {} groups.

Co-Authored-By: Oz <oz-agent@warp.dev>
@dannyneira
dannyneira force-pushed the independabot/brace-expansion-CVE-2026-13149 branch from b7de53e to a387633 Compare July 27, 2026 22:09
@dannyneira
dannyneira enabled auto-merge (squash) July 27, 2026 22:10
@dannyneira
dannyneira merged commit b7e2f7b into main Jul 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants