fix: update brace-expansion to resolve CVE-2026-13149 - #188
Conversation
|
Holding off on approval and merge for now:
Per review policy, major-version dependency bumps are not auto-merged. Please verify the bump is safe for the build toolchain and merge manually if appropriate. |
dannyneira
left a comment
There was a problem hiding this comment.
Verified locally on a fresh clone of warpdotdev/workflows with this PR branch checked out (Node v24.15.0, npm 11.12.1).
Install: npm ci in build_ts/ succeeded (186 packages; brace-expansion resolved to 5.0.8 per the overrides block, balanced-match to 4.0.4). The repo's own prepare script (npm run build) ran during install and completed.
Build: npm run build (tsc && webpack) passed — "webpack 5.107.2 compiled successfully"; dist/warp-workflows.js (243 KiB), index.d.ts, index.js, and index.js.map emitted.
Typecheck: npx tsc --noEmit passed with no errors.
Lint / test: no lint or test scripts are defined in build_ts/package.json, so those steps are not applicable.
prepare script review (called out in the Dependabot release notes): brace-expansion 5.0.8 declares "prepare": "tshy". tshy is a standard, dev-only TypeScript dual-package build tool; npm does not run prepare for registry-installed dependencies, and tshy is listed under devDependencies (not installed transitively), so this script does not execute during npm ci. The published tarball ships pre-built dist/. No unexpected install-time behavior observed. (The transitive balanced-match@4.0.4 has the same benign prepare: tshy pattern.) brace-expansion is a transitive dependency via nodemon and is not part of the build output.
All defined verification steps pass. Safe to merge.
Add npm overrides to force brace-expansion >= 1.1.16, resolving
DoS vulnerability via exponential-time expansion of consecutive
non-expanding {} groups.
Co-Authored-By: Oz <oz-agent@warp.dev>
b7de53e to
a387633
Compare
Hi, this is independabot — not Lili! You can ask her if you have questions, but she had no hand in generating this PR other than setting up the independabot schedule.
Please merge this PR yourself, if you approve.
BEFORE YOU MERGE
Instructions for resolving the vuln
brace-expansionupdated from1.1.11→5.0.8(via npmoverridesinbuild_ts/package.json)npm installran successfully (includestsc && webpackbuild);npm auditno longer reports brace-expansion vulnerabilityHighlight the risky code / where the dependency was used
brace-expansionis a transitive dependency ofminimatch(brought in vianodemondevDependency). It is only used in the build toolchain, not in the shipped bundle. Risk is low.Special instructions for this PR
None. This is a devDependency-only change to
build_ts/. Theoverridesfield pinsbrace-expansionto>=1.1.16(resolved to5.0.8at time of install).AFTER YOU MERGE
No post-merge steps required.