f11 fullscreen#921
Open
HEIHUAa wants to merge 6 commits into
Open
Conversation
Contributor
|
Isn't this already provided through the Alt + Enter keybind? |
Contributor
Author
It conflicts with the Enter confirmation key, causing unintended confirmation actions when I toggle fullscreen. Since I switch between fullscreen and windowed mode frequently, this is quite annoying. |
MRK2009
approved these changes
Mar 6, 2026
MRK2009
left a comment
MRK2009
left a comment
Contributor
There was a problem hiding this comment.
I agree with that, nice.
Raltyro
requested changes
Jul 26, 2026
| public function new(gameWidth:Int, gameHeight:Int, entryState:Class<FlxState>, updateFramerate:Int = 60, drawFramerate:Int = 60, skipSplash:Bool = false, startFullscreen:Bool = false) { | ||
| super(gameWidth, gameHeight, entryState, updateFramerate, drawFramerate, skipSplash, startFullscreen); | ||
|
|
||
| fullscreenListener = function(e:KeyboardEvent) { |
Member
There was a problem hiding this comment.
Can it be in override create(_):Void instead of in public function new?
and the fullscreenListener function should be just a normal function
Contributor
Author
There was a problem hiding this comment.
Makes sense, I'll change it later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add F11 fullscreen functionality.
Remove F key fullscreen functionality from
TitleState.