-
-
Notifications
You must be signed in to change notification settings - Fork 343
f11 fullscreen #921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HEIHUAa
wants to merge
6
commits into
CodenameCrew:main
Choose a base branch
from
HEIHUAa:fullscreen
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+19
−2
Open
f11 fullscreen #921
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3e6b998
f11 fullscreen
HEIHUAa df07e88
Compilation conditions
HEIHUAa b87ab73
Merge branch 'CodenameCrew:main' into fullscreen
HEIHUAa 1104832
Merge branch 'CodenameCrew:main' into fullscreen
HEIHUAa f55ed89
Merge branch 'CodenameCrew:main' into fullscreen
HEIHUAa d09bb64
Merge branch 'CodenameCrew:main' into fullscreen
HEIHUAa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be in
override create(_):Voidinstead of inpublic function new?and the fullscreenListener function should be just a normal function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, I'll change it later.